Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fix in the ping test module used by CCF. #483

Conversation

prakashngit
Copy link
Contributor

loguru warning method is warning() and not warn()

@bvavala
Copy link
Member

bvavala commented Apr 2, 2024

I think loguru uses logging underneath, so your fix should be related to this problem python/cpython#105376 (i.e., warn is deprecated).

Could this be generalized and replace all warn in the repo with warning?

@cmickeyb
Copy link
Contributor

cmickeyb commented Apr 2, 2024

I think loguru uses logging underneath, so your fix should be related to this problem python/cpython#105376 (i.e., warn is deprecated).

Could this be generalized and replace all warn in the repo with warning?
good suggestion. create an issue for this?
here's the reference: https://docs.python.org/3/library/logging.html#logging.Logger.warning

Copy link
Contributor

@cmickeyb cmickeyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

…hod is warning() and not warn()

Signed-off-by: Prakash Narayana Moorthy <[email protected]>
@prakashngit prakashngit force-pushed the Prakash.Fix_logging_statement_used_in_CCF_ping branch from ea6431e to a1e94a4 Compare April 10, 2024 15:46
@cmickeyb cmickeyb merged commit e203535 into hyperledger-labs:main Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants