-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Conflict Detection in Parallelization by Considering Slots to Reduce False Positives #7923
Conversation
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
we need to do stability tests before merging |
Signed-off-by: Karim Taam <[email protected]>
...ava/org/hyperledger/besu/ethereum/mainnet/parallelization/MainnetParallelBlockProcessor.java
Show resolved
Hide resolved
Signed-off-by: Karim Taam <[email protected]>
...hereum/trie/diffbased/common/worldview/accumulator/DiffBasedWorldStateUpdateAccumulator.java
Outdated
Show resolved
Hide resolved
- copy storageKeyHashLookup when cloning accumulator Signed-off-by: Karim Taam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog entry?
...java/org/hyperledger/besu/ethereum/mainnet/parallelization/TransactionCollisionDetector.java
Outdated
Show resolved
Hide resolved
...java/org/hyperledger/besu/ethereum/mainnet/parallelization/TransactionCollisionDetector.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Karim Taam <[email protected]>
68a5c15
to
85bfd20
Compare
Signed-off-by: Karim Taam <[email protected]>
788f628
to
9985e73
Compare
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, comparing with the first version of the parallelization, this PR has better performances even on 4 Cores, without more overhead. Conflict detection takes even less time than the first version.
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
done |
Signed-off-by: Karim Taam <[email protected]>
0a23a9b
to
552bc52
Compare
PR description
This update improve conflict detection during transaction parallelization by checking storage slot changes. By considering modified slots in addition to addresses, we improve the accuracy of conflict detection.
Key Changes:
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests