Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove k8s NAT method #8289

Merged
merged 4 commits into from
Feb 13, 2025
Merged

remove k8s NAT method #8289

merged 4 commits into from
Feb 13, 2025

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Feb 12, 2025

PR description

K8s NAT method was deprecated in 24.10.0

Also removes this dependency 'io.kubernetes:client-java:21.0.1-legacy'

Fixed Issue(s)

Fixes #7533

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla added doc-change-required Indicates an issue or PR that requires doc to be updated breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking. labels Feb 12, 2025
@macfarla
Copy link
Contributor Author

@joshuafernandes any specific testing you want to see on this?

@joshuafernandes
Copy link
Contributor

@joshuafernandes any specific testing you want to see on this?

All good @macfarla I'll be good to close this one out esp given the k8s APIs have long since changed. Thankyou!

Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla enabled auto-merge February 13, 2025 22:46
@macfarla macfarla added this pull request to the merge queue Feb 13, 2025
@macfarla macfarla disabled auto-merge February 13, 2025 23:53
@macfarla macfarla merged commit 6791c5f into hyperledger:main Feb 13, 2025
43 checks passed
@macfarla macfarla deleted the rm-k8s-nat branch February 17, 2025 05:28
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove deprecated k8s nat method
4 participants