Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] update use of gradle deprecated features #8295

Merged
merged 11 commits into from
Feb 16, 2025

Conversation

macfarla
Copy link
Contributor

Signed-off-by: Sally MacFarlane [email protected]

PR description

There's a few features that are set to be removed in gradle 9

This PR is built on top of #8294

Upgrade notes here
https://docs.gradle.org/8.11/userguide/upgrading_version_8.html#changes_8.11

Think the remaining warning is via web3j compileSolidity task

The Project.exec(Closure) method has been deprecated. This is scheduled to be removed in Gradle 9.0. Use ExecOperations.exec(Action) or ProviderFactory.exec(Action) instead. Consult the upgrading guide for further information: https://docs.gradle.org/8.11/userguide/upgrading_version_8.html#deprecated_project_exec

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla added the dev experience The build system, things that enable easier development etc. label Feb 13, 2025
@macfarla macfarla mentioned this pull request Feb 13, 2025
9 tasks
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 13, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@macfarla macfarla added this pull request to the merge queue Feb 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 14, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@macfarla macfarla added this pull request to the merge queue Feb 14, 2025
@macfarla macfarla added this pull request to the merge queue Feb 14, 2025
@macfarla macfarla merged commit 1508b5c into hyperledger:main Feb 16, 2025
43 checks passed
@macfarla macfarla deleted the gradle-deprecations branch February 16, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev experience The build system, things that enable easier development etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants