Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the cleanup of subprocesses after each AT #8306

Merged
merged 3 commits into from
Feb 15, 2025

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Feb 14, 2025

PR description

Fix acceptance test failures correctly closing spawn processes after each test, also abstract common methods of JSON RPC Authentication tests

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the fix-cleanup-after-each-AT branch 2 times, most recently from b231be8 to 4a7ecaf Compare February 14, 2025 11:48
@fab-10 fab-10 force-pushed the fix-cleanup-after-each-AT branch from 4a7ecaf to 34c6a8c Compare February 14, 2025 11:52
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10 fab-10 force-pushed the fix-cleanup-after-each-AT branch from 2e356a4 to d9f98da Compare February 14, 2025 13:37
@fab-10 fab-10 force-pushed the fix-cleanup-after-each-AT branch from d9f98da to b964d5f Compare February 14, 2025 13:39
@fab-10 fab-10 marked this pull request as ready for review February 14, 2025 13:57
@fab-10 fab-10 enabled auto-merge (squash) February 14, 2025 14:04
@fab-10 fab-10 merged commit ccb23ab into hyperledger:main Feb 15, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants