Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QbftBlockHashing as this is provided by the block hash #8311

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Feb 17, 2025

PR description

Removes the QbftBlockHashing interface as the same functionality is provided by creating a commitBlock and using its hash. This makes reusing the Qbft library easier too as there no assumptions that the commit hash can be derived from the blockheader and extradata.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it need a changelog entry?

@jframe
Copy link
Contributor Author

jframe commented Feb 17, 2025

does it need a changelog entry?

Don't think so, it's internal refactoring. And there is nothing documented about the QBFT core module at the moment. So don't think we need to do anything.

@jframe jframe changed the title Remove QbftBlockHashing service as this is provided by the block hash Remove QbftBlockHashing as this is provided by the block hash Feb 17, 2025
@jframe jframe merged commit efcefad into hyperledger:main Feb 17, 2025
43 checks passed
@jframe jframe deleted the qbft_removeBlockHashing branch February 17, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants