Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace HttpClient with WebSocketClient in EthStatsService #8327

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KYash03
Copy link

@KYash03 KYash03 commented Feb 19, 2025

Fixes #8313

@macfarla
Copy link
Contributor

when I run gw compileTestJava I get this error

Execution failed for task ':ethereum:ethstats:compileTestJava'.
> Compilation failed; see the compiler output below.
  /Users/sm/workspace/b2/ethereum/ethstats/src/test/java/org/hyperledger/besu/ethstats/EthStatsServiceTest.java:219: warning: [UnusedMethod] Method 'succeededWebSocketEvent' is never used.
    private <T> AsyncResult<T> succeededWebSocketEvent(final Optional<T> object) {

Do the tests still make sense without this?

@KYash03 KYash03 force-pushed the refactor-ethstats branch 2 times, most recently from 874df2b to f9850d8 Compare February 19, 2025 05:57
@KYash03
Copy link
Author

KYash03 commented Feb 19, 2025

I seem to have missed that. I've removed succeededWebSocketEvent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor EthStatsService creation of WebSocket
2 participants