Java off-chain data store sample using Fabric Gateway #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestbeforetoday
force-pushed
the
off-chain-data
branch
2 times, most recently
from
baf249a
to
512bd67
Compare
Also minor implementation changes to TypeScript sample for better consistency between implementations. Signed-off-by: Mark S. Lewis <[email protected]>
bestbeforetoday
force-pushed
the
off-chain-data
branch
from
512bd67
to
b74f80b
Compare
mbwhite
reviewed
May 25, 2022
| import org.hyperledger.fabric.client.EndorseException; | ||
| import org.hyperledger.fabric.client.SubmitException; | ||
|
|
||
| public final class AssetTransferBasic { |
There was a problem hiding this comment.
Should this be called something other than' AssetTransferBasic'?
To avoid confusion.
There was a problem hiding this comment.
It's the client application view of the asset-transfer-basic smart contract so the name seems reasonable to me, and aligns with the naming in the corresponding TypeScript sample:
I could change them both if you have a better name for them.
There was a problem hiding this comment.
no; not got a better name ;-)
so long as it was a conscious decision 👍
There was a problem hiding this comment.
Conscious but not necessarily a good one 🤣
mbwhite
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also minor implementation changes to TypeScript sample for better consistency between implementations.
Contributes to hyperledger/fabric-gateway#190