Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsString helper function to JSONAny #103

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Conversation

nguyer
Copy link
Contributor

@nguyer nguyer commented Oct 3, 2023

Previously if a JSONAny was actually a JSON String it was cumbersome to get it as a plain string. This helper function makes it easier everywhere we need to do that.

Signed-off-by: Nicko Guyer <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #103 (8b19051) into main (6f614c3) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              main     #103      +/-   ##
===========================================
- Coverage   100.00%   99.94%   -0.06%     
===========================================
  Files           63       63              
  Lines         5048     5054       +6     
===========================================
+ Hits          5048     5051       +3     
- Misses           0        2       +2     
- Partials         0        1       +1     
Files Coverage Δ
pkg/fftypes/jsonany.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@peterbroadhurst peterbroadhurst merged commit 046ec28 into main Oct 31, 2023
2 checks passed
@peterbroadhurst peterbroadhurst deleted the jsonanystring branch October 31, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants