fix: delete stream with name #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enrique Lacal <[email protected]>
peterbroadhurst
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Change looks great thanks @EnriqueL8 - one small build issue to address before merge.
Signed-off-by: Enrique Lacal <[email protected]>
EnriqueL8
force-pushed
the
fix_delete_stream
branch
from
5780414
to
2e24d70
Compare
peterbroadhurst
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting we add an IDFilter so that the SQL query results in
DELETE FROM table WHERE ID = <value>in the case of deleting stream we were passing the nameOrID to that SQL query and it was failing when we passed the name. Since we retrieve the value from the DB before deleting we can just pass in the ID to delete