Adding support for leaky bucket throttling (rps + burst) in ffresty client #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chengxuan Xing <[email protected]>
…-config Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Chengxuan
changed the title
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
EnriqueL8
previously requested changes
May 31, 2024
|
@EnriqueL8 thanks for the review. Replied to your comments |
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
…-config Signed-off-by: Chengxuan Xing <[email protected]>
peterbroadhurst
requested changes
Jun 6, 2024
Signed-off-by: Chengxuan Xing <[email protected]>
|
@peterbroadhurst comments addressed |
Signed-off-by: Chengxuan Xing <[email protected]>
Chengxuan
changed the title
Chengxuan
changed the title
peterbroadhurst
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Thanks @Chengxuan for the extra spelling round there - looks great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
throttlesection as a configuration so the ffresty client can submit requests at certain rates using leaky bucket style throttling control.Note: this option is not optimal if other clients are using the REST endpoint under the same rate limit bucket.
To handle scenarios like that, we should update ffresty client to be Retry-after header aware or allow users to provide custom handling logic if they use different standards.