Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create block filters before poll interval #152

Merged
merged 13 commits into from
Sep 6, 2024
Merged

Create block filters before poll interval #152

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1343bbd
Create block filters before poll interval
rodion-lim-partior Aug 27, 2024
182eebe
Block listener should notify when block filter is established
rodion-lim-partior Aug 30, 2024
1031762
Correct failing tests
rodion-lim-partior Sep 3, 2024
676a441
Add tests for defering checkStartedLocked till block filters are created
rodion-lim-partior Sep 3, 2024
7ae9785
Lock block listener loop started flag
rodion-lim-partior Sep 4, 2024
6c43218
Fix PR review comments
rodion-lim-partior Sep 5, 2024
99c4a1c
refactor tests
Chengxuan Sep 5, 2024
837f0a8
downscoping the locking for get highest block
Chengxuan Sep 5, 2024
ed72634
more tidy up
Chengxuan Sep 5, 2024
7f002f4
fixing test coverage
Chengxuan Sep 5, 2024
57f1df0
Merge branch 'main' of github.com:kaleido-io/firefly-evmconnect into …
Chengxuan Sep 5, 2024
a8a5247
fixing tests
Chengxuan Sep 5, 2024
f9c618e
Fix lint failures
rodion-lim-partior Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lock block listener loop started flag 
Signed-off-by: rodion <rodion.lim@partior.com>
  • Loading branch information
@rodion-lim-partior
rodion-lim-partior committed Sep 4, 2024
commit 7ae9785a5071cc3623587288073a76e53f7b0bf2
7 changes: 5 additions & 2 deletions internal/ethereum/blocklistener.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,8 @@ func (bl *blockListener) listenLoop() {
log.L(bl.ctx).Errorf("Failed to establish new block filter: %s", err.Message)
failCount++
continue
} else {
bl.setBlockFilterStatus()
}
bl.setBlockFilterStatus()
}

var blockHashes []ethtypes.HexBytes0xPrefix
Expand Down Expand Up @@ -519,9 +518,13 @@ func (bl *blockListener) dispatchToConsumers(consumers []*blockUpdateConsumer, u
}

func (bl *blockListener) checkStartedLocked(ctx context.Context) {
bl.mux.Lock()
if bl.listenLoopDone == nil {
bl.listenLoopDone = make(chan struct{})
bl.mux.Unlock()
go bl.listenLoop()
} else {
bl.mux.Unlock()
}

bl.blockTillBlockFilterEstablished(ctx)
Expand Down