Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding latency metrics to the report and fixing actionsPerLoop #72

Merged
merged 18 commits into from
Nov 14, 2023

Conversation

Chengxuan
Copy link
Contributor

@Chengxuan Chengxuan commented Nov 8, 2023

  • Actions in a loop are not emitted in parallel. Based on description: This can be helpful when you want to scale the number of actions done in parallel without having to scale the number of workers. I believe it's intended that actions should be triggered in parallel.

It's not clear when should one add more workers vs set more actions per loop to scale the number of requests. My thinking is that we could bind workers to a specific signing address in the future, so if one want multiple requests per signing address then they tune actionsPerWorker if they want more signing addresses to send requests, then they add more workers

  • Add latency metrics
  • Support for generating an HTML report at the test run
  • Report latency metrics in the final report

Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
@Chengxuan Chengxuan marked this pull request as ready for review November 9, 2023 17:09
Chengxuan and others added 4 commits November 10, 2023 13:01
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Copy link
Member

@shorsher shorsher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 thanks @Chengxuan

@shorsher shorsher merged commit ede6115 into hyperledger:main Nov 14, 2023
2 checks passed
@shorsher shorsher deleted the latency_metrics branch November 14, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants