Add Builder Codes #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmlmt
reviewed
Nov 29, 2024
|
This is marked as a draft. Did you test/is it ready to be merged? |
I'm in the process of adding the |
|
Hey @lmlmt, the code is ready for review and to be merged |
lmlmt
reviewed
Dec 21, 2024
|
@Frixoe Can you make sure it compiles? The continuous integration is now failing so would be good to make sure that's in a good spot before merging. |
|
@lmlmt sorry completely forget about my arch nemesis clippy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the initial builder codes approval code having referenced it from the python sdk and I think I'm missing something in the implementation related to my understanding of the builders code API.
When I tried running it initially I got a 422 and now I get a 403 but that's probably a personal environment issue. But would be great to get some feedback on the current implementation. Please ignore the info! lines.