Add Builder Codes #66
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmlmt
reviewed
Nov 29, 2024
| @@ -293,3 +293,10 @@ pub struct VaultTransfer { | |||
| pub struct SetReferrer { | |||
| pub code: String, | |||
| } | |||
|
|
|||
| #[derive(Serialize, Deserialize, Debug, Clone)] | |||
There was a problem hiding this comment.
Suggested change
| #[derive(Serialize, Deserialize, Debug, Clone)] | |
| #[derive(Debug, Clone, Serialize, Deserialize)] |
There was a problem hiding this comment.
But every other action has the derive attribute traits in that order. Should I still change it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the initial builder codes approval code having referenced it from the python sdk and I think I'm missing something in the implementation related to my understanding of the builders code API.
When I tried running it initially I got a 422 and now I get a 403 but that's probably a personal environment issue. But would be great to get some feedback on the current implementation. Please ignore the info! lines.