Skip to content

Replace ethers-rs with alloy #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gnapoli23
Copy link

@gnapoli23 gnapoli23 commented Feb 19, 2025

@namn-grg

I saw that #85 was still pending and did the last changes, consisting in using feature-based version of alloy.

I forked @androolloyd branch so he could not loose his commits, and appended my changes.

BTW, if you agree, I would also like to remove all those annoying warnings popping up.

@namn-grg
Copy link
Contributor

namn-grg commented Feb 19, 2025

Thanks for the PR, looks good from going over it. Will do deeper review and testing this week

I would also like to remove all those annoying warnings popping up.

which warnings are you referring to?

@0xPatryk
Copy link

Thanks a lot for the PR, there are still some features/examples missing. Could u Issue them and than I can review it.

Or just ping me on which features u want me to implement and I'll work on top of your pr to add those features (to avoid double work)

We need to force someone from HL to give one of us maintainer roles, as it is possible that his branch will be open for weeks :D

@gnapoli23
Copy link
Author

gnapoli23 commented Feb 19, 2025

Thanks for the PR, looks good from going over it. Will do deeper review and testing this week

I would also like to remove all those annoying warnings popping up.

which warnings are you referring to?

I'm referring to clippy warnings, I would use this PR to cleanup those warnings and add a couple of cargo fmt runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants