CORE-3229: Forward signals from proxy models to their concrete models #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
danielfbnunes
force-pushed
the
daniel.nunes/CORE-3229-forward-signals-from-proxy-models-to-their-concrete-models
branch
from
528f9fc to
245ece1
Compare
jimmyjiji
reviewed
Nov 6, 2023
jimmyjiji
approved these changes
Nov 6, 2023
Right! We don't maintain the changes in this repo from a test perspective so I've put all the tests in this draft. |
georgi-yanchev
approved these changes
Nov 6, 2023
JPDSousa
approved these changes
Nov 7, 2023
danielfbnunes
deleted the
daniel.nunes/CORE-3229-forward-signals-from-proxy-models-to-their-concrete-models
branch
|
Related feature request in django: https://code.djangoproject.com/ticket/9318 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward signals from proxy models to their concrete models. Here's the draft that tests this change.
If you're questioning yourself about the
m2m_changedsignal, we don't need to do anything there because thesenderis the m2m relation which is the same whether we start from the proxy model (ProxyModel.m2m_field.through) or the concrete model (ConcreteModel.m2m_field.through).