Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook modal dialog is not properly represented as a dialog #6158

Closed
Tracked by #6151
acelaya opened this issue Jan 31, 2024 · 0 comments · Fixed by #6187
Closed
Tracked by #6151

Notebook modal dialog is not properly represented as a dialog #6158

acelaya opened this issue Jan 31, 2024 · 0 comments · Fixed by #6187
Assignees

Comments

@acelaya
Copy link
Contributor

acelaya commented Jan 31, 2024

Part of #6151

To make the dialog more accessible:

  1. Add a role=”dialog” to the dialog container. This will allow assistive technologies to announce the dialog as it appears.
  2. Add an aria-modal=”true” attribute to the dialog. This will hide background content from assistive technologies while the modal is open.
  3. Shift keyboard focus into the dialog when it opens, and constrain focus within the modal until the user closes the dialog.
@acelaya acelaya changed the title Notebook modal dialog is not properly represented as a dialog (eg. with appropriate roles and focus handling) Notebook modal dialog is not properly represented as a dialog Jan 31, 2024
@acelaya acelaya self-assigned this Jan 31, 2024
@acelaya acelaya moved this to In Progress in Accessibility improvements Jan 31, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Accessibility improvements Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
1 participant