-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display notebook in a native dialog #6187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
force-pushed
the
notebook-native-dialog
branch
2 times, most recently
from
February 8, 2024 09:25
bacdd8f
to
5f3dc9c
Compare
acelaya
force-pushed
the
notebook-native-dialog
branch
from
February 8, 2024 09:27
5f3dc9c
to
9cc709e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6187 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 266 266
Lines 10086 10108 +22
Branches 2391 2395 +4
=======================================
+ Hits 10030 10052 +22
Misses 56 56 ☔ View full report in Codecov by Sentry. |
acelaya
force-pushed
the
notebook-native-dialog
branch
2 times, most recently
from
February 8, 2024 09:49
d70dfc8
to
d7b69f8
Compare
acelaya
commented
Feb 8, 2024
acelaya
force-pushed
the
notebook-native-dialog
branch
3 times, most recently
from
February 8, 2024 10:16
7d05f12
to
5b7daab
Compare
acelaya
commented
Feb 8, 2024
robertknight
reviewed
Feb 8, 2024
acelaya
force-pushed
the
notebook-native-dialog
branch
from
February 8, 2024 11:41
5b7daab
to
ca352d3
Compare
robertknight
approved these changes
Feb 8, 2024
acelaya
force-pushed
the
notebook-native-dialog
branch
from
February 8, 2024 15:53
ca352d3
to
65b196a
Compare
This was referenced Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6158
This PR is an alternative to #6162, which tries to use a native
dialog
element to display the notebook.The benefit of this is that it requires very little changes and solves
role="dialog"
,aria-modal="true"
and focus trapping out of the box.The main drawback is that there are older versions of browsers we still support which don't support
dialog
. In those cases we will continue rendering the old less accessible markup, until all browsers we support can usedialog
elements.The good thing is that less-than-two-years-old browsers support
dialog
, so that will be the triggered branch in most of the cases.Testing steps
On a modern browser, the notebook should look the same, but focus should be trapped, and pressing Tab should never focus an element outside of it.
To test old browsers behavior, open
NotebookModal
and editisModalDialogSupported
:With this, the notebook should look and behave as in
main
branch.TODO
dialog
.