Add accessible names to profile and notebook dialogs #6222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the work from #6187, the has been a second accessibility review, which has highlighted the lack of an accessible name for the notebook dialog.
We have been suggested to use
aria-labelledby
to do this, which is also the recommendation in https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/dialog_role.However, since the label value is not displayed anywhere else, this PR implements a solution using
aria-label
instead.