Exclude if TYPE_CHECKING: blocks from coverage
#191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanh
added a commit
that referenced
this pull request
Jan 10, 2025
seanh
added a commit
that referenced
this pull request
Jan 10, 2025
marcospri
approved these changes
Jan 13, 2025
This is extracted from #188 as a separate PR. This commit also adds includes for per-project overriding or extending of the coverage excludes: * If a project has a `.cookiecutter/includes/coverage/exclude_also` file that will _replace_ the cookiecutter's default `exclude_also`'s * If a project has a `.cookiecutter/includes/coverage/exclude_also/tail` file that will _extend_ the cookiecutter's default `exclude_also`'s Also fix a bug in `local_extensions.py`'s `include_exists(path)` function: don't crash if there's a _folder_ (rather than a file) at `path` (the code was catching the wrong exception class, looks like just a mistake).
seanh
force-pushed
the
exclude-TYPE_CHECKING-blocks-from-coverage
branch
from
731fa0e to
d2e7938
Compare
seanh
added a commit
that referenced
this pull request
Jan 17, 2025
seanh
added a commit
that referenced
this pull request
Jan 17, 2025
seanh
added a commit
that referenced
this pull request
Jan 17, 2025
seanh
added a commit
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extracted from
#188 as a separate PR.
This commit also adds includes for per-project overriding or extending
of the coverage excludes:
If a project has a
.cookiecutter/includes/coverage/exclude_alsofilethat will replace the cookiecutter's default
exclude_also'sIf a project has a
.cookiecutter/includes/coverage/exclude_also/tailfilethat will extend the cookiecutter's default
exclude_also'sAlso fix a bug in
local_extensions.py'sinclude_exists(path)function:don't crash if there's a folder (rather than a file) at
path(thecode was catching the wrong exception class, looks like just a mistake).