Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further increase frequence of the fill pk task in H #349

Closed
wants to merge 1 commit into from

Conversation

marcospri
Copy link
Member

@marcospri marcospri commented Sep 8, 2023

"schedule": crontab(hour="*,9-12", minute="*/15"),
"kwargs": {"batch_size": 10000},
"schedule": crontab(hour="*,6-12", minute="*/10"),
"kwargs": {"batch_size": 15000},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe more, 50k?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long is this going to take to complete given the current DB size and growth rate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this rate over two months, new annotations are not that important, we can (and should) soon update the code so they don't need this, setting the pk and user_id in python when they are created.

@marcospri marcospri requested a review from seanh September 8, 2023 12:37
Start earlier, do the task every 10 minutes and for a bigger batch size
"schedule": crontab(hour="9-12", minute="*/15"),
"kwargs": {"batch_size": 10000},
"schedule": crontab(hour="5-12", minute="*/10"),
"kwargs": {"batch_size": 15000},
Copy link
Member Author

@marcospri marcospri Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tasks have already gone over the time limit:

https://hypothesis.sentry.io/issues/4465586542/?referrer=slack&notification_uuid=adaafa01-d50f-4c25-b0ec-8cf3a50b4e10&alert_rule_id=7345746&alert_type=issue

I don't think we should increase, 4 min is plenty of time. Looking at NR looks like the first run of the day it usually slow? I guess after that postgres makes room on ram for the indices?

@marcospri
Copy link
Member Author

Closed in favor of #351

@marcospri marcospri closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants