Include the since/until parameters for H slim task #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dates here take into account the progress made so far and move the window forward a few months to see the impact on performance. In theory a very big window will degrade performance significantly as it will need to visit more annotations.
marcospri
commented
Nov 16, 2023
| @@ -55,14 +58,22 @@ | |||
| "fill-annotation-slim-first-batch": { | |||
| "options": {"expires": 30}, | |||
| "task": "h.tasks.annotations.fill_annotation_slim", | |||
| "schedule": crontab(hour="7", minute="*/3"), | |||
| "kwargs": {"batch_size": 250}, | |||
| "schedule": crontab(hour="7", minute="*/2"), | |||
There was a problem hiding this comment.
Change this from 3 -> 2 to be inline with the one below.
marcospri
commented
Nov 16, 2023
| @@ -17,6 +17,9 @@ | |||
| print("h_beat disabled by DISABLE_H_BEAT environment variable") | |||
| sys.exit() | |||
|
|
|||
| SLIM_TASK_SINCE = "2016-01-01" | |||
There was a problem hiding this comment.
Having these here will make it easier to make follow up PRs.
marcospri
commented
Nov 16, 2023
| "kwargs": { | ||
| "batch_size": 250, | ||
| "since": SLIM_TASK_SINCE, | ||
| "until": SLIM_TASK_UNTIL, |
There was a problem hiding this comment.
Names match the task parameters: https://github.com/hypothesis/h/blob/main/h/tasks/annotations.py#L9
marcospri
commented
Nov 16, 2023
| @@ -17,6 +17,9 @@ | |||
| print("h_beat disabled by DISABLE_H_BEAT environment variable") | |||
| sys.exit() | |||
|
|
|||
| SLIM_TASK_SINCE = "2016-01-01" | |||
marcospri
commented
Nov 16, 2023
| @@ -17,6 +17,9 @@ | |||
| print("h_beat disabled by DISABLE_H_BEAT environment variable") | |||
| sys.exit() | |||
|
|
|||
| SLIM_TASK_SINCE = "2016-01-01" | |||
| SLIM_TASK_UNTIL = "2018-03-31" | |||
There was a problem hiding this comment.
Include a few more months worth of annotations in the window over the default value.
acelaya
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dates here take into account the progress made so far and move the window forward a few months to see the impact on performance.
In theory a very big window will degrade performance significantly as it will need to visit more annotations.