Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease send_instructor_email_digests batch size again #389

Merged

Conversation

seanh
Copy link
Contributor

@seanh seanh commented Nov 21, 2023

Decrease the batch size of the send_instructor_email_digests() Celery
task again, this time decreasing it 10x from 10 to 1.

This is to enable us to see whether we could get away with removing the
batching feature. We'll attempt to maintain the speed at which emails
are generated at about the same rate by simultaneously increasing the
task's rate limit, see: hypothesis/lms#5841

Slack thread: https://hypothes-is.slack.com/archives/C1MA4E9B9/p1700130444868909?thread_ts=1699980253.387059&cid=C1MA4E9B9

Decrease the batch size of the `send_instructor_email_digests()` Celery
task again, this time decreasing it 10x from `10` to `1`.

This is to enable us to see whether we could get away with removing the
batching feature. We'll attempt to maintain the speed at which emails
are generated at about the same rate by simultaneously increasing the
task's rate limit, see: hypothesis/lms#5841

Slack thread: https://hypothes-is.slack.com/archives/C1MA4E9B9/p1700130444868909?thread_ts=1699980253.387059&cid=C1MA4E9B9
@seanh seanh requested a review from marcospri November 21, 2023 13:03
@seanh seanh changed the title Decrease send_instructor_email_digests batch size again Decrease send_instructor_email_digests batch size again Nov 21, 2023
@seanh seanh merged commit 85ce4a7 into main Nov 21, 2023
8 checks passed
@seanh seanh deleted the decrease-send_instructor_email_digest_tasks-batch-size-again branch November 21, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants