Disable automatic reloading of assets in production #4138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In production builds, avoid stat-ing the manifest and bundle files on
each call to Environment.url since the assets never change until the
service is re-deployed.
See #4128 (comment)
FWIW I did some basic benchmarking of
os.path.getmtime()
locally. When all of the calls hit the stat cache, my system can manage ~1M calls/sec (native) or ~300K calls/sec (Docker container). On that basis I think it is quite unlikely that this would ever end up being a bottleneck, but adding a flag doesn't add much complexity either.