Add group_members feature flag
#9062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't affect order in the admin dashboard, as flags were already sorted by name there. It just makes it easier to skim the list.
This a flag to control whether the new group forms display the members table.
robertknight
commented
Nov 1, 2024
| "pdf_custom_text_layer": "Use custom text layer in PDFs for improved text selection", | ||
| "styled_highlight_clusters": "Style different clusters of highlights in the client", | ||
| "client_user_profile": "Enable client-side user profile and preferences management", | ||
| "group_type": "Allow users to choose group type in group creation form", |
There was a problem hiding this comment.
While adding this flag I sorted the existing ones by name to make it more obvious where to slot new entries in. Looking at the rest of the code in this file it shouldn't matter what order the entries are in, and the admin UI already sorted flags for display, so there is no change there.
seanh
approved these changes
Nov 7, 2024
| "pdf_custom_text_layer": "Use custom text layer in PDFs for improved text selection", | ||
| "styled_highlight_clusters": "Style different clusters of highlights in the client", | ||
| "client_user_profile": "Enable client-side user profile and preferences management", | ||
| "group_type": "Allow users to choose group type in group creation form", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a flag to control whether the new group forms display the members table.
Part of #9063.