Scope roster FF to the dashboard group

hypothesis · Nov 25, 2024 · 46802f5 · 46802f5
1 parent 25db53e
commit 46802f5
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/lms/models/application_instance.py b/lms/models/application_instance.py
@@ -57,7 +57,7 @@ class ApplicationSettings(JSONSettings):
         JSONSetting("hypothesis", "lti_13_sourcedid_for_grading", asbool),
         JSONSetting("hypothesis", "auto_grading_enabled", asbool),
         JSONSetting("hypothesis", "auto_grading_sync_enabled", asbool),
-        JSONSetting("hypothesis", "dashboard_rosters", asbool),
+        JSONSetting("dashboard", "rosters", asbool),
         JSONSetting("dashboard", "assignment_segments_filter_enabled", asbool),
     )
 

diff --git a/lms/services/dashboard.py b/lms/services/dashboard.py
@@ -182,7 +182,7 @@ def get_assignment_roster(
         rosters_enabled = (
             assignment.course
             and assignment.course.application_instance.settings.get(
-                "hypothesis", "dashboard_rosters"
+                "dashboard", "rosters"
             )
         )
         if rosters_enabled and self._roster_service.assignment_roster_exists(

diff --git a/lms/templates/admin/application_instance/show.html.jinja2 b/lms/templates/admin/application_instance/show.html.jinja2
@@ -120,7 +120,7 @@
                         <fieldset class="box">
                             <legend class="label has-text-centered">Dashboard settings</legend>
                             {{ settings_checkbox("Enable segments filter in assignment view", "dashboard", "assignment_segments_filter_enabled", default=False) }}
-                            {{ settings_checkbox("Enable roster data", "hypothesis", "dashboard_rosters", default=False) }}
+                            {{ settings_checkbox("Enable roster data", "dashboard", "rosters", default=False) }}
                         </fieldset>
                         <fieldset class="box">
                             <legend class="label has-text-centered">Canvas settings</legend>

diff --git a/tests/unit/lms/services/dashboard_test.py b/tests/unit/lms/services/dashboard_test.py
@@ -240,7 +240,7 @@ def test_get_assignment_roster_with_roster_disabled(
     def test_get_assignment_roster_with(
         self, svc, application_instance, roster_service
     ):
-        application_instance.settings.set("hypothesis", "dashboard_rosters", True)
+        application_instance.settings.set("dashboard", "rosters", True)
         assignment = factories.Assignment(
             course=factories.Course(application_instance=application_instance)
         )