Remove ignores that don't take effect until check_untyped_defs is ena…

…bled
hypothesis · Jun 25, 2024 · 678c29a · 678c29a
1 parent d0b7d41
commit 678c29a
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/lms/extensions/feature_flags/__init__.py b/lms/extensions/feature_flags/__init__.py
@@ -176,7 +176,7 @@ def feature(request, feature_flag_name):
 
     def add_feature_flag_providers(_config, *providers):
         """Adapt feature_flags.add_providers()."""
-        providers = [config.maybe_dotted(provider) for provider in providers]  # type:ignore
+        providers = [config.maybe_dotted(provider) for provider in providers]
         return feature_flags.add_providers(*providers)
 
     # Register the Pyramid request method and config directive. These are this

diff --git a/lms/services/group_info.py b/lms/services/group_info.py
@@ -46,7 +46,7 @@ def upsert_group_info(self, grouping: Grouping, params: dict):
         # AI should be many:many, and we reflect that wrongness here.
         group_info.application_instance = grouping.application_instance
 
-        group_info.type = self._GROUPING_TYPES[grouping.type]  # type: ignore
+        group_info.type = self._GROUPING_TYPES[grouping.type]
 
         for field in [
             # Most (all) of these are duplicated elsewhere, we'll keep updating for now

diff --git a/lms/validation/_lti_launch_params.py b/lms/validation/_lti_launch_params.py
@@ -132,7 +132,7 @@ def handle_error(self, error, data, *, many, **kwargs):
             # ``err.messages``, but without overwriting any of the existing
             # error messages already present in ``messages``.
             for field in err.messages:
-                messages.setdefault(field, []).extend(err.messages[field])  # type:ignore
+                messages.setdefault(field, []).extend(err.messages[field])
             return_url = None
 
         if return_url:

diff --git a/lms/views/admin/_schemas.py b/lms/views/admin/_schemas.py
@@ -19,7 +19,7 @@ def deserialize(self, value, attr, data, **kwargs):
         # pylint:disable=compare-to-empty-string
         if value == missing or value.strip() == "":
             return None
-        return super().deserialize(value, attr, data, **kwargs)  # type:ignore
+        return super().deserialize(value, attr, data, **kwargs)
 
 
 class EmptyStringInt(EmptyStringNoneMixin, fields.Int):  # type: ignore

diff --git a/lms/views/api/blackboard/files.py b/lms/views/api/blackboard/files.py
@@ -76,7 +76,7 @@ def via_url(self):
 
         document_url = self.request.params["document_url"]
         file_id = course.get_mapped_file_id(
-            DOCUMENT_URL_REGEX.search(document_url)["file_id"]  # type: ignore
+            DOCUMENT_URL_REGEX.search(document_url)["file_id"]
         )
         try:
             if self.request.lti_user.is_instructor: