Add logging to detect concurrent token refreshes for most OAuth APIs #6322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a step towards preventing concurrent refreshes for all OAuth APIs, try to acquire the advisory lock on all OAuth token refreshes performed by `OAuthHTTPService`, but only prevent concurrent refreshes when the caller opts-in, which currently means only Canvas Studio. Otherwise we just write a log entry so we can count how often concurrent refreshes occur.
robertknight
force-pushed
the
concurrent-refresh-log
branch
from
73bc32d to
1efd7a3
Compare
seanh
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a step towards preventing concurrent refreshes for all OAuth APIs, try to acquire the advisory lock on all OAuth token refreshes performed by
OAuthHTTPService, but only prevent concurrent refreshes when the caller opts-in, which currently means only Canvas Studio. Otherwise we just write a log entry so we can count how often concurrent refreshes occur.Tested with our D2L site for example, the log entries look like: