Unify error codes used for typechecking and at runtime #6391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
reviewed
Jun 25, 2024
| | 'moodle_student_not_in_group' | ||
| | 'vitalsource_no_book_license' | ||
| | 'vitalsource_user_not_found'; | ||
| (typeof ltiLaunchServerErrorCodes)[number]; |
There was a problem hiding this comment.
So this is "type of the elements in the array"?
There was a problem hiding this comment.
Yes, exactly. It is expressed as "get type of value returned by indexing into the array with a number".
marcospri
approved these changes
Jun 25, 2024
Unify the lists of LTI error codes used for typechecking and matched at runtime against server error messages. This makes adding new error codes easier and avoids a potential hazard where a new error code is added to one list but not the other.
robertknight
force-pushed
the
unify-compile-runtime-error-codes
branch
from
6144412 to
aff59f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #6390.
Unify the lists of LTI error codes used for typechecking and matched at runtime
against server error messages.
This makes adding new error codes easier and avoids a potential hazard where a
new error code is added to one list but not the other.