Make sure process.env.NODE_ENV is stringified #6471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
commented
Jul 25, 2024
| @@ -38,7 +38,7 @@ function bundleConfig(name, entryFile) { | |||
| replace({ | |||
| preventAssignment: true, | |||
| values: { | |||
| 'process.env.NODE_ENV': process.env.NODE_ENV, | |||
| 'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV), | |||
There was a problem hiding this comment.
This ensures it is still undefined if not provided, but it gets quoted as an inline string if it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some rollup config to replace
process.env.NODE_ENVwith their actual values, but incorrectly set to do it as a direct replacement.That meant that if
NODE_ENV=production, it would replaceprocess.env.NODE_ENVby the literal valueproduction, which is then treated as a variable, causing aReferenceError: production is not definederror.This PR fixes that by JSON-encoding the value of
process.env.NODE_ENVbefore replacing it in code, as seen in the docs https://www.npmjs.com/package/@rollup/plugin-replace