Enforce dashboard admin access for assignments and users #6475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
commented
Jul 29, 2024
| @@ -8,14 +8,16 @@ | |||
|
|
|||
|
|
|||
| class DashboardService: | |||
| def __init__(self, db, assignment_service, course_service, organization_service): | |||
| self._db = db | |||
| def __init__( | |||
There was a problem hiding this comment.
In this module we check access to individual elements.
| @@ -214,32 +217,51 @@ def is_member(self, assignment: Assignment, h_userid: str) -> bool: | |||
| def get_assignments( | |||
| self, | |||
| instructor_h_userid: str | None = None, | |||
| admin_organization_ids: list[int] | None = None, | |||
There was a problem hiding this comment.
Same pattern as for courses, fetch assignments where the users is an instructor or an admin.
| @@ -117,6 +121,7 @@ def get_users( # noqa: PLR0913, PLR0917 | |||
| :param role_scope: return only users with this LTI role scope. | |||
| :param role_type: return only users with this LTI role type. | |||
| :param instructor_h_userid: return only users that belongs to courses/assignments where the user instructor_h_userid is an instructor. | |||
| :param admin_organization_ids: organizations where the current user is an admin. | |||
There was a problem hiding this comment.
Fetch users from courses where the users is an instructor or an admin.
acelaya
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the same pattern as #6467 to assignments and users
Testing
As a teacher and admin
[email protected]as an admin the relevant organization, eg: http://localhost:8001/admin/orgs/1/dashboard-admins