Models for LMSCourse and LMSUser #6573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
commented
Aug 21, 2024
|
|
||
| __table_args__ = (sa.UniqueConstraint("application_instance_id", "lms_course_id"),) | ||
|
|
||
| id: Mapped[int] = mapped_column(autoincrement=True, primary_key=True) |
There was a problem hiding this comment.
We have to resist the temptation to make composed primark keys in table like this, (application_instance_id, lms_course_id) is a great PK now but it prevents any easy modifications of the table.
seanh
approved these changes
Aug 22, 2024
lms/models/lms_course.py
Outdated
| id: Mapped[int] = mapped_column(autoincrement=True, primary_key=True) | ||
|
|
||
| tool_consumer_instance_guid: Mapped[str | None] = mapped_column( | ||
| sa.UnicodeText, index=True |
There was a problem hiding this comment.
Do you actually need the sa.UnicodeText when already using Mapped[str]? I think SQLAlchemy chooses the right type automatically?
There was a problem hiding this comment.
Yeah, I think we can settle on the type chosen by SQLAlchemy for str.
There's many types it could chose String, Unicode, UnicdeText, it chooses the equivalent of String/Unicode which we use in many columns. I think we can settle on that.
marcospri
force-pushed
the
lms-course-user-migrations
branch
from
6f8baa5 to
20867a3
Compare
marcospri
force-pushed
the
lms-course-user-models
branch
from
baa67df to
231dc8d
Compare
marcospri
force-pushed
the
lms-course-user-models
branch
from
231dc8d to
8881f66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
For:
Migration for these over: