Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration: Backfill LMSUSerApplication instance #6591

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Migration: Backfill LMSUSerApplication instance #6591

merged 1 commit into from
Aug 29, 2024

Conversation

marcospri
Copy link
Member

@marcospri marcospri commented Aug 23, 2024 •
edited
Loading

For:

Testing

tox -e dev --run-command 'alembic upgrade head'
dev run-test-pre: PYTHONHASHSEED='2408596744'
dev run-test-pre: commands[0] | pip-sync-faster requirements/dev.txt --pip-args --disable-pip-version-check
dev run-test: commands[0] | alembic upgrade head
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade f61cb94edfc8 -> e13fb37c96e5, Backfill lms_user_application_instance.

@marcospri marcospri mentioned this pull request Aug 23, 2024
Open
21 tasks
@marcospri marcospri force-pushed the backfill-lms-course branch from fc905f2 to 19d6790 Compare August 23, 2024 11:30
@marcospri marcospri force-pushed the backfill-lms-user-ai branch from 6a7af15 to b18dedc Compare August 23, 2024 11:36
marcospri
marcospri commented Aug 23, 2024
View reviewed changes
lms/migrations/versions/e13fb37c96e5_backfill_lms_user_application_instance.py
FROM "user"
JOIN lms_user on lms_user.h_userid = "user".h_userid
)
INSERT INTO lms_user_application_instance (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably possible the same migration where we filled LMSCourse.

Doing it a separate one for more clarity

@marcospri marcospri requested a review from seanh August 23, 2024 14:22
@marcospri marcospri marked this pull request as ready for review August 23, 2024 14:22
@marcospri marcospri force-pushed the backfill-lms-course branch 2 times, most recently from 34eb70d to 9d4b7e4 Compare August 29, 2024 07:19
Base automatically changed from backfill-lms-course to main August 29, 2024 07:23
@marcospri marcospri force-pushed the backfill-lms-user-ai branch 2 times, most recently from 1c234f0 to a19fe5b Compare August 29, 2024 07:30
@marcospri marcospri force-pushed the backfill-lms-user-ai branch from a19fe5b to 112394a Compare August 29, 2024 14:39
@marcospri marcospri merged commit 2c92976 into main Aug 29, 2024
9 checks passed
@marcospri marcospri deleted the backfill-lms-user-ai branch August 29, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanh seanh seanh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcospri @seanh