Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration: Backfill LMSCourseApplication instance #6592

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Migration: Backfill LMSCourseApplication instance #6592

merged 1 commit into from
Aug 29, 2024

Conversation

marcospri
Copy link
Member

@marcospri marcospri commented Aug 23, 2024 •
edited
Loading

For:

Testing

tox -e dev --run-command 'alembic upgrade head'        

dev run-test-pre: PYTHONHASHSEED='427507881'
dev run-test-pre: commands[0] | pip-sync-faster requirements/dev.txt --pip-args --disable-pip-version-check
dev run-test: commands[0] | alembic upgrade head
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade e13fb37c96e5 -> 9e79650bed37, LMSCourseApplicationInstance backfill.

@marcospri marcospri mentioned this pull request Aug 23, 2024
Open
21 tasks
@marcospri marcospri force-pushed the backfill-lms-course-ai branch from 2437488 to 88b7175 Compare August 23, 2024 10:48
@marcospri marcospri force-pushed the backfill-lms-user-ai branch from 6a7af15 to b18dedc Compare August 23, 2024 11:36
@marcospri marcospri force-pushed the backfill-lms-course-ai branch from 88b7175 to 1194984 Compare August 23, 2024 12:17
@marcospri marcospri requested a review from seanh August 26, 2024 12:52
@marcospri marcospri marked this pull request as ready for review August 28, 2024 07:22
seanh
seanh approved these changes Aug 29, 2024
View reviewed changes
lms/migrations/versions/9e79650bed37_backfill_lms_course_application_instance.py
SELECT
"grouping".created,
"grouping".updated,
lms_course.id lms_course_id,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an AS missing here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, AS is optional but arguably the query would be more clear with it.

@marcospri marcospri force-pushed the backfill-lms-user-ai branch 2 times, most recently from 1c234f0 to a19fe5b Compare August 29, 2024 07:30
@marcospri marcospri force-pushed the backfill-lms-course-ai branch 2 times, most recently from 03871a3 to 1321cc4 Compare August 29, 2024 12:57
@marcospri marcospri force-pushed the backfill-lms-user-ai branch from a19fe5b to 112394a Compare August 29, 2024 14:39
Base automatically changed from backfill-lms-user-ai to main August 29, 2024 14:46
@marcospri marcospri force-pushed the backfill-lms-course-ai branch from 1321cc4 to 12d01d7 Compare August 29, 2024 14:48
@marcospri marcospri merged commit e08bf70 into main Aug 29, 2024
9 checks passed
@marcospri marcospri deleted the backfill-lms-course-ai branch August 29, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanh seanh seanh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcospri @seanh