-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose roster information on the user metrics endpoint #6871
Conversation
9af7c04
to
6e8b16e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except that I think we should not make the API contract more complex with more nested levels.
It will also be easier to support both assignments with reoster and without roster, by making the FE know the only difference is that the active
prop may not be there at all.
6e8b16e
to
c6bf186
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
* Add roster sync indicator * Add message when assignment students do not come from roster (#6905)
48e1891
to
961499c
Compare
Proposed changes to the API structure to accommodate roster meta-information on the metrics endpoint.
That endpoint currently return a list of students, update it to return an APIRoster object which does contain the same APIStudent entries augmented with:
active: bool, for each student.
last_udpaetd: datetime, for the whole roster.
Once we agree on a API format we could:
More context: