Return the actual value for RosterEntry.active #6907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
force-pushed
the
roster-dashboard-api
branch
from
48e1891 to
961499c
Compare
marcospri
force-pushed
the
roster-dashboard-api-active
branch
from
913c92f to
e256c71
Compare
marcospri
force-pushed
the
roster-dashboard-api-active
branch
from
e256c71 to
0d1b070
Compare
marcospri
commented
Dec 11, 2024
| .join(LMSUser, AssignmentRoster.lms_user_id == LMSUser.id) | ||
| .join(LTIRole, AssignmentRoster.lti_role_id == LTIRole.id) | ||
| .where(AssignmentRoster.assignment_id == assignment.id) | ||
| ).distinct() |
There was a problem hiding this comment.
As we now use a join we have to return distinct rows.
In the spec is not possible to get a user active with one role but inactive with another so we'll always get unique users here.
marcospri
changed the title
acelaya
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been returning
Truefor all entries until now. Actually return the value on the DB for roster entries andTruefor the ones based on launches.Testing
https://hypothesis.instructure.com/courses/125/assignments/873
You get the list of students. No "drop" badges.
https://hypothesis.instructure.com/courses/319/assignments/3336
make shell:Open the dashboard, you'll get the list of students, no badges.
On
make sql, set everyone as inactive:DROPbadge!