Get D2L API ID on user service #7016
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
commented
Feb 12, 2025
| @@ -654,16 +654,6 @@ def _get_course_users(self, lms_course: LMSCourse) -> dict[str, LMSUser]: | |||
| ).all() | |||
| return {u.lms_api_user_id: u for u in users} | |||
|
|
|||
| def _get_lms_api_user_id(self, member: Member, family: Family) -> str | None: | |||
There was a problem hiding this comment.
Move this to UserService
We already have a mechanism to get this ID from roster data. Extend it to be usable directly on user service and reuse the same method in RosterService.
marcospri
force-pushed
the
d2l-api-id-user-service
branch
from
b19010f to
47bd6da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have a mechanism to get this ID from roster data.
Extend it to be usable directly on user service and reuse the same method in RosterService.
Testing
truncate lms_user CASCADE;Launch two LTI1.3 assignments as any user, in D2L and Canvas
https://aunltd.brightspacedemo.com/d2l/le/content/6782/viewContent/2132/View
https://hypothesis.instructure.com/courses/319/assignments/3308
Check the data in the DB, you should have two users with IDs:
truncate lms_user CASCADE;