Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading bar doesn't finish on Checkmate pages #501

Open
seanh opened this issue May 19, 2021 · 1 comment
Open

Loading bar doesn't finish on Checkmate pages #501

seanh opened this issue May 19, 2021 · 1 comment

Comments

@seanh
Copy link
Contributor

seanh commented May 19, 2021

When a URL is blocked by Checkmate the loading bar appears and starts loading but never completes. Example:

https://via.hypothes.is/https://example.com/publisher-blocked

Slack thread: https://hypothes-is.slack.com/archives/C1M8NH76X/p1621360348014500
@seanh seanh changed the title Loading bar is broken on Checkmate pages Loading bar doesn't finish on Checkmate pages May 19, 2021
@seanh seanh mentioned this issue May 19, 2021
Open
@robertknight
Copy link
Member

robertknight commented Jun 29, 2023 •
edited
Loading

See #1020 for how this same issue was fixed in the context of our video player. The TL;DR is that the top Via frame relies on the content frame sending it a message with the page URL and title, via window.postMessage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertknight @seanh