implemented follow_mouse_threshold #9392
Open
+26
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Feb 13, 2025
vaxerski
reviewed
Feb 15, 2025
src/config/ConfigDescriptions.hpp
Outdated
| @@ -501,6 +501,12 @@ inline static const std::vector<SConfigOptionDescription> CONFIG_OPTIONS = { | |||
| .type = CONFIG_OPTION_INT, | |||
| .data = SConfigOptionDescription::SRangeData{1, 0, 3}, | |||
| }, | |||
| SConfigOptionDescription{ | |||
| .value = "input:follow_mouse_threshold", | |||
| .description = "The smallest distance the mouse needs to travel for the window under it to get focused, works only with follow_mouse = 1.", | |||
There was a problem hiding this comment.
missing unit, should mention in logical pixels
andrewandreii
force-pushed
the
patch_follow_mouse_threshold
branch
from
b84baa9 to
c80e10e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Adds feature described in #9328. It introduces a new config variable input:follow_mouse_threshold
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I am not very familiar with this codebase so I did my best to understand what's happening, but please check if I got everything right!
I am unsure about the
|| refocusin the last if before we callfocusWindow, is it pointless?Another thing is the magic constant that I used to determine if a mouse movement is "tied" to the last mouse movement or not (if they happened within 0.5 seconds of each other, they are considered to be the same mouse movement)
Is it ready for merging, or does it need work?
Yes, it's ready to be merged