Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xwayland): prevent clipboard race condition #9394

Merged
merged 3 commits into from
Feb 15, 2025
Merged

fix(xwayland): prevent clipboard race condition #9394

merged 3 commits into from
Feb 15, 2025

Conversation

nnyyxxxx
Copy link
Contributor

fixes #9393

@nnyyxxxx nnyyxxxx mentioned this pull request Feb 12, 2025
Closed
6 tasks
@nnyyxxxx nnyyxxxx changed the title fix(xwayland): prevent race condition when copying text to clipboard too fast fix(xwayland): prevent clipboard race condition Feb 12, 2025
@nnyyxxxx nnyyxxxx marked this pull request as ready for review February 12, 2025 15:18
@nnyyxxxx nnyyxxxx marked this pull request as draft February 12, 2025 15:20
@nnyyxxxx
Copy link
Contributor Author

this is ready

@nnyyxxxx nnyyxxxx marked this pull request as ready for review February 13, 2025 20:48
vaxerski
vaxerski reviewed Feb 14, 2025
View reviewed changes
src/xwayland/XDataSource.cpp Outdated Show resolved Hide resolved
src/xwayland/XWM.cpp Outdated Show resolved Hide resolved
src/xwayland/XWM.cpp Outdated Show resolved Hide resolved
src/xwayland/XWM.cpp Outdated Show resolved Hide resolved
src/xwayland/XWM.cpp Outdated Show resolved Hide resolved
@nnyyxxxx
Copy link
Contributor Author

@vaxerski all done

vaxerski
vaxerski reviewed Feb 15, 2025
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that ok

src/xwayland/XWM.cpp Outdated Show resolved Hide resolved
vaxerski
vaxerski approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanku

@vaxerski vaxerski merged commit 9228116 into hyprwm:main Feb 15, 2025
12 checks passed
@nnyyxxxx nnyyxxxx deleted the patch-1 branch February 16, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees
No one assigned
Labels
core xwayland
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xwayland: Clipboard listener sometimes receives empty content
2 participants
@nnyyxxxx @vaxerski