rfc: 1-animation-slide-side #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NotAShelf is this important enough for an RFC? I think this should just be an enhancement request in hl |
|
It could be a topic for the RFC if it proposed an entire refactor, but it completely ignores the RFC format. |
|
"hey can we do this" is not a good RFC topic. A good RFC
|
|
Could you let me qualify this as a draft and work on it using your feedbacks? |
|
Do feel free. I'll provide a quick review tomorrow. |
beside the motivation the rest wasn't modified yet but will be
Some sections are still empty, i don't know what to put it there by reading the template. But I will fill these up if remarks/questions are asked.
I don't know if it is, but it's already implemented and it seems like i have a diverging point of view from the implementation, I thought the best way to settle this was an RFC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find the implementation wierd with sides.
Decided to use this space to get feedbacks