WIP: Just Another expressioN system #320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExpressionTableScan is responsible for handing the parameters and tables to the Expression. Similar to other table scans, but with less functionality. ExpressionLibrary is a singleton which keeps track of all available expressions and works as a dispatcher. Expression is the base class for all further expressions
generator.py generates expressions which are defined in expressionsToGenerate.txt The generated expressions are derived from class Expression (see 8167c63) and built by using the ExpressionTemplate(CPP|H).tpl MAnual in src/lib/access/expressions/expressionGeneration/generatedExpressions/README.md
Before all types of expressions were evaluated on values only. Now EQ expressions are evaluated on valueIds.
and introduce generation log
|
Can one of the admins verify this patch? |
|
test this please |
|
add to whitelist |
|
Test failed. |
|
Test PASSED! |
|
@Bensk1 Can you please rebase the PR to the current master and squash it? |
Conflicts: .gitignore src/lib/access/expressions/GenericExpressions.cpp src/lib/access/expressions/GenericExpressions.h src/lib/access/expressions/GenericExpressions.inc test/autojson/DISABLED_load_insert_merge_find_par.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces genericExpressions by introducing a similar approach, but instead of using macro and boost magic it uses a python script to fill a Jinja2 template. Documentation can be found in src/lib/access/expressions/expressionGeneration/README.md and the attached image illustrates the structure of this system.