-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(setup): add setup wizard and script runner #34
Conversation
3c0febc
to
d9b8495
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. However, I would prefer the JS version for better usability and cross compatibility.
@@ -74,7 +74,7 @@ web_modules/ | |||
.yarn-integrity | |||
|
|||
# dotenv environment variable files | |||
.env | |||
.env* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would ignore all examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example is named example.env
-> it should not be a hidden file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. However, I would prefer the JS version for better usability and cross compatibility.
This is not feasible, people have trouble installing and configuring docker, node
/ nvm
/ npm
is an unreasonable requirement for stack and it's not pre-installed on any OS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know. Therefore we should test this on other platforms like Linux / Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation fails for me with podman desktop (both with the podman compose provider, and docker compose provider).
Details here
@planetf1 Do you have docker or rancher installed as well? It's preferred in the script. Should I add another question to select a docker provider? I think most people have only one |
Signed-off-by: Radek Ježek <[email protected]>
0cfd2ef
to
90c4b56
Compare
Signed-off-by: Radek Ježek <[email protected]>
90c4b56
to
e53e705
Compare
I don't have docker (desktop) installed on macOS due to licensing/policy + technically too easy to get into messy clashes, especially when using podman in compatibility mode. Similarly for rancher, though that remains installed (without compatibility set up) I do have it on linux podman has been a bit tricky in the past, but the most recent releases are a lot better with compatibility - most things now work. It's also the most license-friendly implementation (rancher is also good), so I think it's quite important to have support for . podman also supports either the docker-compose provider, or it's internal one. Ideally it would be better to support either (especially as the plugin then becomes a global configuration). Neither seemed to past the test when I tried the PR earlier :-( I can take a look at the script checks in more detail if it helps. |
We cannot support outdated (v1) compose commands, the We support these, the appropriate should now be selected automatically if the version meets the requirements (>= 2.29):
You are of course free to use the manual section and run it however you wish, it's a compose file after all... |
Add setup script for bee-stack:
Ref: #6 #15 #5