Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(apps): protocol #171

Merged
merged 10 commits into from
Jan 8, 2025
Merged

refactor(apps): protocol #171

merged 10 commits into from
Jan 8, 2025
+58 −93

Conversation

JanPokorny
Copy link
Contributor

@JanPokorny JanPokorny commented Jan 7, 2025 •
edited
Loading

These PRs need to be merged and deployed together:

Changes (in all these PRs):

  • Simplify messaging and state handling -- synchronize a single state object between apps
  • Use the request mechanism for "Fix error"
  • Send ready event as soon as the app starts running (perceptively faster app load)
  • Track ancestor origin, avoid a barrage of mismatched origin warnings in console
  • Properly sync the sandboxed frame if it reloads by itself (useful in dev)
  • Unify naming in some cases

This was referenced Jan 8, 2025
Merged
Merged
@JanPokorny JanPokorny marked this pull request as ready for review January 8, 2025 13:55
@JanPokorny JanPokorny requested a review from a team as a code owner January 8, 2025 13:55
@JanPokorny JanPokorny merged commit ed7727b into main Jan 8, 2025
2 checks passed
@JanPokorny JanPokorny deleted the janpokorny/refactor-apps-protocol branch January 8, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jezekra1 jezekra1 jezekra1 approved these changes

@Tomas2D Tomas2D Tomas2D approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JanPokorny @Tomas2D @jezekra1