Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move bee_hive to root level #162

Closed
wants to merge 1 commit into from
Closed

Conversation

psschwei
Copy link
Collaborator

@psschwei psschwei commented Jan 30, 2025

bee-py code has all moved to its own repo, so let's remove it from here and move bee_hive to main level

Signed-off-by: Paul S. Schweigert <[email protected]>
Copy link
Collaborator

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Thx

@@ -8,7 +8,7 @@
import dotenv
from openai import OpenAI
import yaml
from workflow import Workflow
from bee_hive.workflow import Workflow
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is appropriate - it depends on how we want to manage imports

If we want relative imports within the package, we may want to begin with . or ..
but if we qualify by module (bee_hive), it seems as if the code will work in more situations - this is why the test code currently uses the same construct. For example tests/bee/test_bee.py . It also will be consistent with external use.

The directory moving isn't relevant here, since the module name has remained constant, rather than being a path

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is why the test code currently uses the same construct

I'd keep it consistent for now... if down the line it causes problems we can always refactor

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we will plan this big change after POC1 demos?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that and once the bee-py repo goes public

@planetf1
Copy link
Collaborator

See comment above ref test code, otherwise looks good

@psschwei
Copy link
Collaborator Author

psschwei commented Feb 5, 2025

will revisit this after we make more moves into this repo

@psschwei psschwei closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants