-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move bee_hive to root level #162
Conversation
Signed-off-by: Paul S. Schweigert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it. Thx
@@ -8,7 +8,7 @@ | |||
import dotenv | |||
from openai import OpenAI | |||
import yaml | |||
from workflow import Workflow | |||
from bee_hive.workflow import Workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is appropriate - it depends on how we want to manage imports
If we want relative imports within the package, we may want to begin with . or ..
but if we qualify by module (bee_hive), it seems as if the code will work in more situations - this is why the test code currently uses the same construct. For example tests/bee/test_bee.py . It also will be consistent with external use.
The directory moving isn't relevant here, since the module name has remained constant, rather than being a path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is why the test code currently uses the same construct
I'd keep it consistent for now... if down the line it causes problems we can always refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we will plan this big change after POC1 demos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that and once the bee-py repo goes public
See comment above ref test code, otherwise looks good |
will revisit this after we make more moves into this repo |
bee-py code has all moved to its own repo, so let's remove it from here and move bee_hive to main level