-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first version of Workflow::to_mermaid method #296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
It looks good. I tried some other workflow files. Some of them got exceptions because the --- a/maestro/src/mermaid.py
+++ b/maestro/src/mermaid.py
@@ -53,15 +53,15 @@ class Mermaid:
def __to_sequenceDiagram(self, sb):
sb += "sequenceDiagram\n"
- for agent in self.workflow['spec']['template']['agents']:
+ for agent in self.workflow['spec']['template'].get('agents'):
sb += f"participant {agent}\n"
steps, i = self.workflow['spec']['template']['steps'], 0
for step in steps:
- agentL = step['agent']
+ agentL = step.get('agent')
agentR = None
if i < (len(steps) - 1):
- agentR = steps[i+1]['agent']
+ agentR = steps[i+1].get('agent')
if agentR != None:
sb += f"{agentL}->>{agentR}: {step['name']}\n"
else:
@@ -84,10 +84,10 @@ class Mermaid:
steps, i = self.workflow['spec']['template']['steps'], 0
for step in steps:
- agentL = step['agent']
+ agentL = step.get('agent')
agentR = None
if i < (len(steps) - 1):
- agentR = steps[i+1]['agent']
+ agentR = steps[i+1].get('agent')
if agentR != None:
sb += f"{agentL}-- {step['name']} -->{agentR}\n"
else:
|
psschwei
reviewed
Mar 11, 2025
Will do. Thx |
and also updated mermaid flowchart and sequenceDiagram links
@akihikokuroda should be good to go! |
akihikokuroda
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #290
Workflow::to_mermaid
Mermaid
class where all the code issequenceDiagram
andflowchart
Only tested with
tests/yamsl/workflows/simple_workflow.yaml
but should work for the others. If not please open bug.Also, does not include representation for
loop
orcondition
orexception
oron
events. I will address these in issue #297