Skip to content

Commit

Permalink
comment nits
Browse files Browse the repository at this point in the history
  • Loading branch information
rtm committed Aug 24, 2007
1 parent 4d39b63 commit 8e88f9e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
2 changes: 1 addition & 1 deletion fs.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// On-disk file system format.
// This header is shared between kernel and user space.
// Both the kernel and user programs use this header file.

// Block 0 is unused.
// Block 1 is super block.
Expand Down
2 changes: 1 addition & 1 deletion fsvar.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ struct inode {
uint dev; // Device number
uint inum; // Inode number
int ref; // Reference count
int flags; // I_BUSY, I_VALID
int flags; // I_BUSY, I_VALID

short type; // copy of disk inode
short major;
Expand Down
7 changes: 1 addition & 6 deletions ide.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@
#define IDE_CMD_READ 0x20
#define IDE_CMD_WRITE 0x30

// IDE request queue.
// ide_queue points to the buf now being read/written to the disk.
// ide_queue->qnext points to the next buf to be processed.
// Must hold ide_lock while manipulating queue.
// You must hold ide_lock while manipulating queue.

static struct spinlock ide_lock;
static struct buf *ide_queue;
Expand Down Expand Up @@ -84,7 +83,6 @@ ide_intr(void)
{
acquire(&ide_lock);
if(ide_queue){
//cprintf("intr %x\n", ide_queue);
if((ide_queue->flags & B_WRITE) == 0)
if(ide_wait_ready(1) >= 0)
insl(0x1F0, ide_queue->data, 512/4);
Expand All @@ -105,7 +103,6 @@ ide_start_request (void)
{
if(ide_queue){
ide_wait_ready(0);
//cprintf("start %x\n", ide_queue);
outb(0x3f6, 0); // generate interrupt
outb(0x1F2, 1); // number of sectors
outb(0x1F3, ide_queue->sector & 0xFF);
Expand Down Expand Up @@ -139,8 +136,6 @@ ide_rw(struct buf *b)
b->done = 0;
b->qnext = 0;

// cprintf("enqueue %x %x\n", b, ide_queue);

// append b to ide_queue
pp = &ide_queue;
while(*pp)
Expand Down

0 comments on commit 8e88f9e

Please sign in to comment.