Merge branch '433-peertest-iae' into 'master'

SSU2: Prevent rare IAE in peer test timer (Gitlab #433) Closes #433 See merge request i2p-hackers/i2p.i2p!121
i2p · Oct 3, 2023 · 1ae663c · 1ae663c
2 parents f0b6638 + cb47880
commit 1ae663c
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/router/java/src/net/i2p/router/transport/udp/PeerTestManager.java b/router/java/src/net/i2p/router/transport/udp/PeerTestManager.java
@@ -356,7 +356,9 @@ public void timeReached() {
                     } else {
                         // received from both Bob and Charlie, but we haven't received a
                         // second message from Charlie yet
-                        sendTestToCharlie();
+                        if (state.getCharliePort() != PENDING_PORT)
+                            sendTestToCharlie();
+                        // else msg 5 wasn't from a valid ip/port ???
                     }
                     if (bobTime > 0 && charlieTime <= 0) {
                         if (state.getBeginTime() + MAX_CHARLIE_LIFETIME < now) {