Router: change logging of floodfill subdb to main subdb in FNDS. Add …

…TODO comments to getLocalClientsBlindData and lookupClientsBySigningPublicKey.
i2p · Sep 4, 2023 · 4e63234 · 4e63234
1 parent 7606731
commit 4e63234
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/router/java/src/net/i2p/router/networkdb/kademlia/FloodfillNetworkDatabaseSegmentor.java b/router/java/src/net/i2p/router/networkdb/kademlia/FloodfillNetworkDatabaseSegmentor.java
@@ -564,7 +564,7 @@ public LeaseSet store(Hash key, LeaseSet leaseSet) {
         }
         FloodfillNetworkDatabaseFacade fndb = _context.mainNetDb();
         if (_log.shouldLog(Log.DEBUG))
-            _log.debug("store " + key.toBase32() + " to floodfill");
+            _log.debug("store " + key.toBase32() + " to main");
         return fndb.store(key, leaseSet);
     }
 
@@ -580,7 +580,7 @@ public RouterInfo store(Hash key, RouterInfo routerInfo) {
         }
         FloodfillNetworkDatabaseFacade fndb = _context.mainNetDb();
         if (_log.shouldLog(Log.DEBUG))
-            _log.debug("store " + key.toBase32() + " to floodfill");
+            _log.debug("store " + key.toBase32() + " to main");
         return fndb.store(key, routerInfo);
     }
 
@@ -904,8 +904,11 @@ public FloodfillNetworkDatabaseFacade localNetDB() {
     public List<BlindData> getLocalClientsBlindData() {
         ArrayList<BlindData> rv = new ArrayList<>();
         for (String subdb : _subDBs.keySet()) {
-            if (subdb.startsWith("clients_"))
-                ;
+            // if (subdb.startsWith("clients_"))
+            // TODO: see if we can access only one subDb at a time when we need
+            // to look up a client by SPK. We mostly need this for managing blinded
+            // and encrypted keys in the Keyring Config UI page. See also
+            // ConfigKeyringHelper
             rv.addAll(_subDBs.get(subdb).getBlindData());
         }
         return rv;
@@ -915,8 +918,11 @@ public List<BlindData> getLocalClientsBlindData() {
     public List<String> lookupClientBySigningPublicKey(SigningPublicKey spk) {
         List<String> rv = new ArrayList<>();
         for (String subdb : _subDBs.keySet()) {
-            if (subdb.startsWith("clients_"))
-                ;
+            // if (subdb.startsWith("clients_"))
+            // TODO: see if we can access only one subDb at a time when we need
+            // to look up a client by SPK. We mostly need this for managing blinded
+            // and encrypted keys in the Keyring Config UI page. See also
+            // ConfigKeyringHelper
             BlindData bd = _subDBs.get(subdb).getBlindData(spk);
             if (bd != null) {
                 rv.add(subdb);