Console: Fix HTML errors on /configupdate

i2p · Dec 1, 2023 · 63d7079 · 63d7079
1 parent 26524e3
commit 63d7079
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/apps/routerconsole/java/src/net/i2p/router/web/ConfigUpdateHelper.java b/apps/routerconsole/java/src/net/i2p/router/web/ConfigUpdateHelper.java
@@ -118,14 +118,14 @@ public String getRefreshFrequencySelectBox() {
         StringBuilder buf = new StringBuilder(256);
         buf.append("<select name=\"refreshFrequency\">");
         for (int i = 0; i < PERIODS.length; i++) {
-            buf.append("<option value=\"").append(PERIODS[i]);
+            buf.append("<option value=\"").append(PERIODS[i]).append("\" ");
             if (PERIODS[i] == ms)
-                buf.append('"').append(SELECTED);
+                buf.append(SELECTED);
 
             if (PERIODS[i] == -1)
-                buf.append("\">").append(_t("Never")).append("</option>\n");
+                buf.append(">").append(_t("Never")).append("</option>\n");
             else
-                buf.append("\">").append(_t("Every")).append(' ').append(DataHelper.formatDuration2(PERIODS[i])).append("</option>\n");
+                buf.append(">").append(_t("Every")).append(' ').append(DataHelper.formatDuration2(PERIODS[i])).append("</option>\n");
         }
         buf.append("</select>\n");
         return buf.toString();

diff --git a/apps/routerconsole/jsp/configupdate.jsp b/apps/routerconsole/jsp/configupdate.jsp
@@ -46,7 +46,7 @@
         <tr><td align="right"><label for="newsThroughProxy"><b><%=intl._t("Fetch news through the proxy?")%></b></label></td>
           <td><jsp:getProperty name="updatehelper" property="newsThroughProxy" /></td></tr>
       <% if (updatehelper.canInstall()) { %>
-        <tr><td align="right"><b><label for="updateThroughProxy"><%=intl._t("Update through the proxy?")%></b></label></td>
+        <tr><td align="right"><label for="updateThroughProxy"><b><%=intl._t("Update through the proxy?")%></b></label></td>
           <td><jsp:getProperty name="updatehelper" property="updateThroughProxy" /></td></tr>
       <% }   // if canInstall %>
         <tr><td align="right"><b><%=intl._t("Proxy host")%>:</b></td>
@@ -60,11 +60,11 @@
           <td><textarea cols="60" rows="6" name="updateURL" wrap="off" spellcheck="false"><jsp:getProperty name="updatehelper" property="updateURL" /></textarea></td>
         </tr><tr><td align="right"><b><%=intl._t("Trusted keys")%>:</b></td>
           <td><textarea cols="60" rows="6" name="trustedKeys" wrap="off" spellcheck="false"><jsp:getProperty name="updatehelper" property="trustedKeys" /></textarea></td></tr>
-        <tr><td id="devSU3build" align="right"><b><label for="updateDevSU3"><%=intl._t("Update with signed development builds?")%></b></label></td>
+        <tr><td id="devSU3build" align="right"><label for="updateDevSU3"><b><%=intl._t("Update with signed development builds?")%></b></label></td>
           <td><jsp:getProperty name="updatehelper" property="updateDevSU3" /></td>
         </tr><tr><td align="right"><b><%=intl._t("Signed Build URL")%>:</b></td>
           <td><input type="text" size="60" name="devSU3URL" value="<jsp:getProperty name="updatehelper" property="devSU3URL" />"></td></tr>
-        <tr><td id="unsignedbuild" align="right"><b><label for="updateUnsigned"><%=intl._t("Update with unsigned development builds?")%></b></label></td>
+        <tr><td id="unsignedbuild" align="right"><label for="updateUnsigned"><b><%=intl._t("Update with unsigned development builds?")%></b></label></td>
           <td><jsp:getProperty name="updatehelper" property="updateUnsigned" /></td>
         </tr><tr><td align="right"><b><%=intl._t("Unsigned Build URL")%>:</b></td>
           <td><input type="text" size="60" name="zipURL" value="<jsp:getProperty name="updatehelper" property="zipURL" />"></td></tr>